softKeystoreUtil.c
------------------
line 813 Why not use OBJ_PREFIX_LEN instead of calling strlen()?
#define OBJ_PREFIX_LEN sizeof (OBJ_PREFIX) - 1
I think that should work.
Everything else looks fine or has been commented on by others.
Mark
Anthony Scarpino wrote:
> I have a whole bunch of bugs ranging from a P2 to P4's.. Most of them
> are only a few lines of change. I'd like review comments by March 20th.
>
> http://cr.opensolaris.org/~izick/bugs/
>
>
> 6439989 CKM_CMS_SIG & WTLS missing from pkcs11_mech2str mapping
> 6282064 C_GetSlotInfo returns CKR_SLOT_ID_INVALID when the logical
> provider is the only slot on the system
> 6177650 Wrong error code returned when key does not allow requested
> operation
> 6437677 C_GenerateKey with missing CKA_VALUE_LEN attr should fail with
> CKR_TEMPLATE_INCOMPLETE
> 6499687 softDSA.c should use a meaningful #define rather than a hard
> coded number
> 6773550 Crypto Framework is too strict when checking DSA key parameters
> 6815120 C_Logout with metaslot can leave metaslot object info in memory
> 6606384 SCF consumers crash after mechanisms are disabled using
> cryptoadm when using libumem
> 6636169 softtoken is confused by .nfs files
> 6636960 C_GetOperationState should fail if there is no active digest
> operation
> 6627939 functional test failure - got
> CKR_UNWRAPPING_KEY_TYPE_INCONSISTENT
>
> _______________________________________________
> crypto-discuss mailing list
> crypto-discuss at opensolaris.org
> http://mail.opensolaris.org/mailman/listinfo/crypto-discuss
