[PATCH] pubkey.h, modexppc.h, ec2n.h, eprecomp.h, ecp.h

[Stephen torri]

pubkey.h: Non-void functions failed to return value;

modexppc.h, ec2n.h, eprecomp.h, ecp.h: Missing virtual destructor.

bash-2.05b$ cvs diff pubkey.h modexppc.h ec2n.h eprecomp.h ecp.h ecp.cpp
Index: pubkey.h
===================================================================
RCS file: /cvsroot/cryptopp/c5/pubkey.h,v
retrieving revision 1.13
diff -U2 -r1.13 pubkey.h
--- pubkey.h    29 Jul 2003 01:18:33 -0000      1.13
+++ pubkey.h    7 Nov 2003 06:02:58 -0000
@@ -443,5 +443,5 @@

        const KEY & GetKey() const {return *m_pKey;}
-       KEY & AccessKey() {throw NotImplemented("TF_ObjectImplExtRef:
cannot modify refererenced key");}
+       KEY & AccessKey() {throw NotImplemented("TF_ObjectImplExtRef:
cannot modify refererenced key");return 0;}

 private:
@@ -922,5 +922,5 @@
        virtual bool Verify(const DL_GroupParameters<T> &params, const
DL_PublicKey<T> &publicKey, const Integer &e, const Integer &r, const
Integer &s) const =0;
        virtual Integer RecoverPresignature(const DL_GroupParameters<T>
&params, const DL_PublicKey<T> &publicKey, const Integer &r, const
Integer &s) const
-               {throw NotImplemented("DL_ElgamalLikeSignatureAlgorithm:
this signature scheme does not support message recovery");}
+               {throw NotImplemented("DL_ElgamalLikeSignatureAlgorithm:
this signature scheme does not support message recovery"); return 0;}
        virtual unsigned int RLen(const DL_GroupParameters<T> &params)
const
                {return params.GetSubgroupOrder().ByteCount();}
Index: modexppc.h
===================================================================
RCS file: /cvsroot/cryptopp/c5/modexppc.h,v
retrieving revision 1.2
diff -U2 -r1.2 modexppc.h
--- modexppc.h  4 Jul 2003 00:17:36 -0000       1.2
+++ modexppc.h  7 Nov 2003 06:02:58 -0000
@@ -15,4 +15,5 @@
 public:
        // DL_GroupPrecomputation
+        virtual ~ModExpPrecomputation(){};
        bool NeedConversions() const {return true;}
        Element ConvertIn(const Element &v) const {return
m_mr->ConvertIn(v);}
Index: ec2n.h
===================================================================
RCS file: /cvsroot/cryptopp/c5/ec2n.h,v
retrieving revision 1.2
diff -U2 -r1.2 ec2n.h
--- ec2n.h      4 Jul 2003 00:17:36 -0000       1.2
+++ ec2n.h      7 Nov 2003 06:02:58 -0000
@@ -97,4 +97,5 @@

        // DL_GroupPrecomputation
+       virtual ~EcPrecomputation<EC2N>(){};
        const AbstractGroup<Element> & GetGroup() const {return m_ec;}
        Element BERDecodeElement(BufferedTransformation &bt) const
{return m_ec.BERDecodePoint(bt);}
Index: eprecomp.h
===================================================================
RCS file: /cvsroot/cryptopp/c5/eprecomp.h,v
retrieving revision 1.1.1.1
diff -U2 -r1.1.1.1 eprecomp.h
--- eprecomp.h  4 Oct 2002 17:31:47 -0000       1.1.1.1
+++ eprecomp.h  7 Nov 2003 06:02:59 -0000
@@ -45,4 +45,5 @@

        // DL_FixedBasePrecomputation
+       virtual ~DL_FixedBasePrecomputationImpl<Element>(){};
        bool IsInitialized() const
                {return !m_bases.empty();}
Index: ecp.h
===================================================================
RCS file: /cvsroot/cryptopp/c5/ecp.h,v
retrieving revision 1.2
diff -U2 -r1.2 ecp.h
--- ecp.h       4 Jul 2003 00:17:36 -0000       1.2
+++ ecp.h       7 Nov 2003 06:02:59 -0000
@@ -99,5 +99,6 @@
 public:
        typedef ECP EllipticCurve;
-
+       virtual ~EcPrecomputation<ECP>(){};
+
        // DL_GroupPrecomputation
        bool NeedConversions() const {return true;}
-- 
Stephen Torri
GPG Key: http://www.cs.wustl.edu/~storri/storri.asc

signature.asc
Description: This is a digitally signed message part