The issue you raised wasn't specifically one of a throws, but a
return value. I didn't read the code, but the comment. What I was
referring to is there is no way for a function to return a value once it has
thrown any exception. The stack has had one or more call popped off of it.
No locality for a return value exists anymore for any of those calls.
If what it is complaining about is a NotImplemented exception being
thrown but not specified I think that is a fair thing to do in code. Do you
really want to carry around handler code through out the library to catch
the NotImplemented or just get a compiler warning? I'd live that warning
very happily, at least until I have completed implementation :-).
73,
Shawn
> -----Original Message-----
> From: Stephen torri [mailto:[EMAIL PROTECTED]
> Sent: Friday, November 07, 2003 2:36 AM
> To: cryptopp
> Subject: RE: [PATCH] pubkey.h, modexppc.h, ec2n.h, eprecomp.h, ecp.h
>
> On Fri, 2003-11-07 at 01:25, Shawn Masters wrote:
> > I'm not sure what good being a language lawyer is going to do in
> > cases like this. In both cases the code is not compromised in the
> least,
> > and the validity of the complaint is in as much question as the code (if
> not
> > more).
>
> I did not believe I was coming across as a language lawyer but as a
> programmer.
>
> > The first case has to be valid just from a logic perspective.
> > Exceptions don't allow multiple bi directional traversals of the stack,
> thus
> > once caught there is no way of doing any of the returns passed along the
> > way.
>
> Can you explain the last part of your sentence? I am not sure, at this
> hour being tired, what you mean by "there is no way of doing any of the
> returns passed along the way".
>
> At the very least with the Verify() function in pubkey.h at line 925 is
> the function is not declaring its going to be throwing a NotImplemented
> exception. If I declare it a call to Verify must be within a try-catch
> block right? Otherwise how will I know that the exception was thrown?
>
> > The second is a style issue at best.
>
> Style is always subjective. I agree with you on that.
>
> Stephen
> --
> Stephen Torri
> GPG Key: http://www.cs.wustl.edu/~storri/storri.asc
