On 2/5/2010 1:13 PM, Mike Gist wrote: > One issue here is deprecation warnings. Those tend to make up the majority. > It would be good if they were optionally enabled inside CS (but always > enabled for projects using deprecated functionality). > I don't know how to go about doing this though.
Deprecation warnings are indeed intended for 3rd-party code, not for within CS itself, which means that they should not show up when building CS. All CS code should be repaired so that it does not employ deprecated functionality. In the few cases where such code is still present (for backward compatibility or such), it usually is possible to disable the deprecation via very localized pre-processor hacks. An example of such (ugly) trickery: http://trac.crystalspace3d.org/trac/CS/changeset/27300 Generally speaking, it probably would be a bad idea to disable deprecation warnings globally within CS since that likely would lead to situations where developers neglect to fix code relying on some other code which they have just deprecated. > I've got into the habit at work of compiling with -Werror, with > deprecation errors not occurring I'd be in favour of enabling that in > CS. It kinda forces you to spend the (usually) few minutes to fix them > as they appear. I also employ -Werror in my own (local) projects for this very reason, however, I am not convinced that it would be workable on a larger scale, such as with CS. A developer can be very careful to commit warning-free code only to learn later that it generates warnings with tools different from the ones he used. Enabling -Werror would then penalize everyone who builds the code from the repository, not just developers with commit access. By "penalize", I mean that the code would fail to compile, which is worse than code which compiles with warnings. -- ES ------------------------------------------------------------------------------ The Planet: dedicated and managed hosting, cloud storage, colocation Stay online with enterprise data centers and the best network in the business Choose flexible plans and management services without long-term contracts Personal 24x7 support from experience hosting pros just a phone call away. http://p.sf.net/sfu/theplanet-com _______________________________________________ Crystal-main mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/crystal-main Unsubscribe: mailto:[email protected]?subject=unsubscribe
