On Fri 22 Dec 2006 at 17:07:04 +0100, Richard Levitte - VMS Whacker wrote: > Mmmm, Rhialto, you have write access to the repo, so if your patch > works, I suggest committing and pushing so we can all try.
Done. I was being careful, just in case somebody would say "Nooooooo! You can't do that because of ...." > I have noticed that random rearrangement of windows, but I've been too > lazy to get bothered with it ;-). I didn't notice right away, I thought maybe I misremembered or something, but then when I realised that I wasn't seeing ghosts it drove me mad :-) > As to indentation, maybe it's time we get into some kind of > agreement. As far as I can see, there's the original twm indentation > (which I suspect, but am unsure of, is X11 indentation), some GNU > indentation and a few more variants that I didn't recognise. Might be > time to write in stone what it should be and suggest the proper emacs > and vim macros to keep them that way. I'm open for suggestion, and > can arrange for that to happen, if we all find it important enough. Due to the mixing of styles some parts of the code are very difficult to understand (for me, at least). For an example of the style that I like, see what DisplayWin() in workmgr.c. It also shows (perhaps now better than first) that and how it can be simplified somewhat (combining conditions instead of lots of nested if-s). An unfortunate disadvantage of a big all-in-one layout change is that it makes difficult to compare changes from before the flag day to those after, especially if you want to revert them for some reason. Too bad that noone seems to have found a perfect solution for that yet :-( (Having said that, I tend to favour an all-in-one layout cleanup though). > Richard -Olaf. -- ___ Olaf 'Rhialto' Seibert -- You author it, and I'll reader it. \X/ rhialto/at/xs4all.nl -- Cetero censeo "authored" delendum esse.
