This is a follow-up to [0], and it basically enables the NTLM tests even if
symbol hiding is enabled (i.e. without the need to pass --disable-symbol-hiding
to configure).

If you run make check now you'll see a bunch of NTLM tests failing. I've run a
quick bisect and it seems that the commit that introduced the breakage is:

86724581b6c02d160b52f817550cfdfc9c93af62 is the first bad commit
commit 86724581b6c02d160b52f817550cfdfc9c93af62
Author: Prash Dush <[email protected]>
Date:   Fri Jan 24 13:01:29 2014 +0000

    ntlm: Added support for NTLMv2

:040000 040000 f4d3be3ff96a3e5e1c7d092d5ea2a11b80b90f3c 
fbf3786792f24453ec63cfc197464c49c1fec527 M      lib

I'm not sure what's the best way to fix this though.

Cheers

[0] http://curl.haxx.se/mail/lib-2014-03/0204.html
From 7dcf769ac7b9c3cd4f7256e3264d4c42ed52a6f3 Mon Sep 17 00:00:00 2001
From: Alessandro Ghedini <[email protected]>
Date: Sun, 25 May 2014 01:22:23 +0200
Subject: [PATCH] tests: run NTLM tests even if symbols hiding is enabled

Bug: http://curl.haxx.se/mail/lib-2014-03/0204.html
---
 tests/libtest/sethostname.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/libtest/sethostname.h b/tests/libtest/sethostname.h
index 192f037..bc6d92e 100644
--- a/tests/libtest/sethostname.h
+++ b/tests/libtest/sethostname.h
@@ -28,7 +28,7 @@
 #  else
 #    define LIBHOSTNAME_EXTERN  __declspec(dllimport)
 #  endif
-#elif defined(BUILDING_LIBCURL) && defined(CURL_HIDDEN_SYMBOLS)
+#elif defined(CURL_HIDDEN_SYMBOLS)
 #  define LIBHOSTNAME_EXTERN CURL_EXTERN_SYMBOL
 #else
 #  define LIBHOSTNAME_EXTERN
-- 
2.0.0.rc4

Attachment: signature.asc
Description: Digital signature

-------------------------------------------------------------------
List admin: http://cool.haxx.se/list/listinfo/curl-library
Etiquette:  http://curl.haxx.se/mail/etiquette.html

Reply via email to