On mer, giu 11, 2014 at 01:01:50 +0200, Kamil Dudka wrote: > On Tuesday, June 10, 2014 20:23:44 Alessandro Ghedini wrote: > > On Sun, May 25, 2014 at 12:43:53PM +0200, Alessandro Ghedini wrote: > > > This is a follow-up to [0], and it basically enables the NTLM tests even > > > if > > > symbol hiding is enabled (i.e. without the need to pass > > > --disable-symbol-hiding to configure). > > > > > > If you run make check now you'll see a bunch of NTLM tests failing. I've > > > run a quick bisect and it seems that the commit that introduced the > > > breakage is: > > > > > > 86724581b6c02d160b52f817550cfdfc9c93af62 is the first bad commit > > > commit 86724581b6c02d160b52f817550cfdfc9c93af62 > > > Author: Prash Dush <[email protected]> > > > Date: Fri Jan 24 13:01:29 2014 +0000 > > > > > > ntlm: Added support for NTLMv2 > > > : > > > :040000 040000 f4d3be3ff96a3e5e1c7d092d5ea2a11b80b90f3c > > > :fbf3786792f24453ec63cfc197464c49c1fec527 M lib> > > > I'm not sure what's the best way to fix this though. > > > > I kinda forgot about this, so... ping? > > I also ended up with the above commit while running git-bisect on curl. The > problem is that NTLM tests are now supported only with a debug build of curl > and there is no plan to change it: > > https://github.com/bagder/curl/commit/0e113070#commitcomment-5711089
Ah, ok. I attached another patch that marks the failing NTLM tests with the "debug" feature so that they are not run unless --enable-debug is used. This should probably be applied before the other patch, to make bisecting easier. The overall result of both patches is that the NTLM tests are run only with --enable-debug even without --disable-symbol-hiding. Cheers
From e84af22120efc6177ebf76837d601fa8bd4a14bf Mon Sep 17 00:00:00 2001 From: Alessandro Ghedini <[email protected]> Date: Wed, 11 Jun 2014 19:18:49 +0200 Subject: [PATCH] tests: add "debug" feature to NTLM tests NTLM tests (since commit 8672458) require a "dummy" nonce value that is only used with debug builds. --- tests/data/test1008 | 1 + tests/data/test1021 | 1 + tests/data/test1100 | 1 + tests/data/test1215 | 1 + tests/data/test150 | 1 + tests/data/test155 | 1 + tests/data/test159 | 1 + tests/data/test169 | 1 + tests/data/test209 | 1 + tests/data/test213 | 1 + tests/data/test239 | 1 + tests/data/test243 | 1 + tests/data/test265 | 1 + tests/data/test267 | 1 + tests/data/test547 | 1 + tests/data/test548 | 1 + tests/data/test555 | 1 + tests/data/test590 | 1 + tests/data/test67 | 1 + tests/data/test68 | 1 + tests/data/test69 | 1 + tests/data/test81 | 1 + tests/data/test822 | 1 + tests/data/test827 | 1 + tests/data/test868 | 1 + tests/data/test873 | 1 + tests/data/test89 | 1 + tests/data/test90 | 1 + tests/data/test906 | 1 + tests/data/test91 | 1 + tests/data/test921 | 1 + 31 files changed, 31 insertions(+) diff --git a/tests/data/test1008 b/tests/data/test1008 index 2618743..604f293 100644 --- a/tests/data/test1008 +++ b/tests/data/test1008 @@ -86,6 +86,7 @@ http <features> NTLM !SSPI +debug </features> <name> HTTP proxy CONNECT auth NTLM with chunked-encoded 407 response diff --git a/tests/data/test1021 b/tests/data/test1021 index 77b75dc..d824942 100644 --- a/tests/data/test1021 +++ b/tests/data/test1021 @@ -92,6 +92,7 @@ http <features> NTLM !SSPI +debug </features> <name> HTTP proxy CONNECT with any proxyauth and proxy offers NTLM and close diff --git a/tests/data/test1100 b/tests/data/test1100 index 6b5ef51..713170f 100644 --- a/tests/data/test1100 +++ b/tests/data/test1100 @@ -64,6 +64,7 @@ This is the final page ! <features> NTLM !SSPI +debug </features> <server> http diff --git a/tests/data/test1215 b/tests/data/test1215 index f43b5e3..dc62b66 100644 --- a/tests/data/test1215 +++ b/tests/data/test1215 @@ -59,6 +59,7 @@ Finally, this is the real page! <features> NTLM !SSPI +debug </features> <server> http diff --git a/tests/data/test150 b/tests/data/test150 index 2b2546f..b45cf46 100644 --- a/tests/data/test150 +++ b/tests/data/test150 @@ -58,6 +58,7 @@ Finally, this is the real page! <features> NTLM !SSPI +debug </features> <server> http diff --git a/tests/data/test155 b/tests/data/test155 index 0a2a999..14a4524 100644 --- a/tests/data/test155 +++ b/tests/data/test155 @@ -77,6 +77,7 @@ Finally, this is the real page! <features> NTLM !SSPI +debug </features> <server> http diff --git a/tests/data/test159 b/tests/data/test159 index 0d53676..3e67118 100644 --- a/tests/data/test159 +++ b/tests/data/test159 @@ -58,6 +58,7 @@ Finally, this is the real page! <features> NTLM !SSPI +debug </features> <server> http diff --git a/tests/data/test169 b/tests/data/test169 index af4595f..5c713a9 100644 --- a/tests/data/test169 +++ b/tests/data/test169 @@ -78,6 +78,7 @@ http <features> NTLM !SSPI +debug </features> <name> HTTP with proxy-requiring-NTLM to site-requiring-Digest diff --git a/tests/data/test209 b/tests/data/test209 index 2f68a15..cfe359b 100644 --- a/tests/data/test209 +++ b/tests/data/test209 @@ -76,6 +76,7 @@ http <features> NTLM !SSPI +debug </features> <name> HTTP proxy CONNECT auth NTLM diff --git a/tests/data/test213 b/tests/data/test213 index 420b58b..ceb89c6 100644 --- a/tests/data/test213 +++ b/tests/data/test213 @@ -76,6 +76,7 @@ http <features> NTLM !SSPI +debug </features> <name> HTTP 1.0 proxy CONNECT auth NTLM and then POST diff --git a/tests/data/test239 b/tests/data/test239 index 1f94a1d..d1ca4e5 100644 --- a/tests/data/test239 +++ b/tests/data/test239 @@ -53,6 +53,7 @@ http <features> NTLM !SSPI +debug </features> <name> HTTP proxy-auth NTLM and then POST diff --git a/tests/data/test243 b/tests/data/test243 index 0ca8621..7d46c0b 100644 --- a/tests/data/test243 +++ b/tests/data/test243 @@ -74,6 +74,7 @@ http <features> NTLM !SSPI +debug </features> <name> HTTP POST with --proxy-anyauth, picking NTLM diff --git a/tests/data/test265 b/tests/data/test265 index fc5a53d..473fbff 100644 --- a/tests/data/test265 +++ b/tests/data/test265 @@ -79,6 +79,7 @@ http <features> NTLM !SSPI +debug </features> <name> HTTP proxy CONNECT auth NTLM and then POST, response-body in the 407 diff --git a/tests/data/test267 b/tests/data/test267 index ce10966..1223347 100644 --- a/tests/data/test267 +++ b/tests/data/test267 @@ -57,6 +57,7 @@ Finally, this is the real page! <features> NTLM !SSPI +debug </features> <server> http diff --git a/tests/data/test547 b/tests/data/test547 index dd4c04e..20a5ab9 100644 --- a/tests/data/test547 +++ b/tests/data/test547 @@ -77,6 +77,7 @@ lib547 <features> NTLM !SSPI +debug </features> <name> HTTP proxy auth NTLM with POST data from read callback diff --git a/tests/data/test548 b/tests/data/test548 index 1983f6f..2d37574 100644 --- a/tests/data/test548 +++ b/tests/data/test548 @@ -77,6 +77,7 @@ lib548 <features> NTLM !SSPI +debug </features> <name> HTTP proxy auth NTLM with POST data from CURLOPT_POSTFIELDS diff --git a/tests/data/test555 b/tests/data/test555 index 03b61f6..6fdd856 100644 --- a/tests/data/test555 +++ b/tests/data/test555 @@ -82,6 +82,7 @@ lib555 <features> NTLM !SSPI +debug </features> <name> HTTP proxy auth NTLM with POST data from read callback multi-if diff --git a/tests/data/test590 b/tests/data/test590 index ed962f0..e726761 100644 --- a/tests/data/test590 +++ b/tests/data/test590 @@ -75,6 +75,7 @@ lib590 <features> NTLM !SSPI +debug </features> <name> HTTP proxy offers Negotiate+NTLM, use only NTLM diff --git a/tests/data/test67 b/tests/data/test67 index 0281698..657b115 100644 --- a/tests/data/test67 +++ b/tests/data/test67 @@ -57,6 +57,7 @@ Finally, this is the real page! <features> NTLM !SSPI +debug </features> <server> http diff --git a/tests/data/test68 b/tests/data/test68 index ef6a461..a67a2f6 100644 --- a/tests/data/test68 +++ b/tests/data/test68 @@ -56,6 +56,7 @@ Wrong password dude. Get it fixed and return. <features> NTLM !SSPI +debug </features> <server> http diff --git a/tests/data/test69 b/tests/data/test69 index 01dcdfc..0281b8b 100644 --- a/tests/data/test69 +++ b/tests/data/test69 @@ -73,6 +73,7 @@ Finally, this is the real page! <features> NTLM !SSPI +debug </features> <server> http diff --git a/tests/data/test81 b/tests/data/test81 index 5243f45..0a48738 100644 --- a/tests/data/test81 +++ b/tests/data/test81 @@ -56,6 +56,7 @@ Finally, this is the real page! <features> NTLM !SSPI +debug </features> <server> http diff --git a/tests/data/test822 b/tests/data/test822 index aef4fd5..1a50e4c 100644 --- a/tests/data/test822 +++ b/tests/data/test822 @@ -36,6 +36,7 @@ imap <features> NTLM !SSPI +debug </features> <name> IMAP NTLM authentication diff --git a/tests/data/test827 b/tests/data/test827 index ed19fc6..14bee48 100644 --- a/tests/data/test827 +++ b/tests/data/test827 @@ -37,6 +37,7 @@ imap <features> NTLM !SSPI +debug </features> <name> IMAP NTLM authentication with initial response diff --git a/tests/data/test868 b/tests/data/test868 index 861e5e6..82bd9b6 100644 --- a/tests/data/test868 +++ b/tests/data/test868 @@ -38,6 +38,7 @@ pop3 <features> NTLM !SSPI +debug </features> <name> POP3 NTLM authentication diff --git a/tests/data/test873 b/tests/data/test873 index 43f9eb8..790c0ac 100644 --- a/tests/data/test873 +++ b/tests/data/test873 @@ -38,6 +38,7 @@ pop3 <features> NTLM !SSPI +debug </features> <name> POP3 NTLM authentication with initial response diff --git a/tests/data/test89 b/tests/data/test89 index 1dee7c1..dc2c1d1 100644 --- a/tests/data/test89 +++ b/tests/data/test89 @@ -90,6 +90,7 @@ Finally, this is the real page! <features> NTLM !SSPI +debug </features> <server> http diff --git a/tests/data/test90 b/tests/data/test90 index 076718f..43f80ee 100644 --- a/tests/data/test90 +++ b/tests/data/test90 @@ -128,6 +128,7 @@ Finally, this is the real page! <features> NTLM !SSPI +debug </features> <server> http diff --git a/tests/data/test906 b/tests/data/test906 index 01f0dd2..4ff6c9f 100644 --- a/tests/data/test906 +++ b/tests/data/test906 @@ -28,6 +28,7 @@ smtp <features> NTLM !SSPI +debug </features> <name> SMTP NTLM authentication diff --git a/tests/data/test91 b/tests/data/test91 index b6d1d1e..0cd9606 100644 --- a/tests/data/test91 +++ b/tests/data/test91 @@ -74,6 +74,7 @@ Finally, this is the real page! <features> NTLM !SSPI +debug </features> <server> http diff --git a/tests/data/test921 b/tests/data/test921 index 78ea8b6..01c8ff9 100644 --- a/tests/data/test921 +++ b/tests/data/test921 @@ -28,6 +28,7 @@ smtp <features> NTLM !SSPI +debug </features> <name> SMTP NTLM authentication with initial response -- 2.0.0
signature.asc
Description: Digital signature
------------------------------------------------------------------- List admin: http://cool.haxx.se/list/listinfo/curl-library Etiquette: http://curl.haxx.se/mail/etiquette.html
