> -----Original Message-----
> From: curl-library [mailto:[email protected]] On Behalf Of
> Steve Holme
> Sent: Tuesday, September 30, 2014 2:12 PM
> To: libcurl development
> Subject: RE: [PATCH] smtps with openssl
>
> On Tue, 30 Sep 2014, Nagel, Bill wrote:
>
>
> > Since this appears to be the precedent, can this patch be merged?
>
>
> I have reworked your diff as a git format patch which is sitting on my machine
> at home ready to be pushed ;-)
>
>
> Can you please give me your opinion on the warnings I mentioned in my last
> email though as I don't want to break other platform builds in the process?
I don't see a problem making eob non-const since, but then we should probably
do this so that we never assign a const char* to a char*:
/* Calculate the EOB taking into account any terminating CRLF from the
previous line of the email or the CRLF of the DATA command when there
is "no mail data". RFC-5321, sect. 4.1.1.4. */
len = SMTP_EOB_LEN;
if(smtp->trailing_crlf || !conn->data->state.infilesize) {
eob = strdup(SMTP_EOB + 2);
len -= 2;
}
else eob = strdup(SMTP_EOB);
-Bill
________________________________
This e-mail contains privileged and confidential information intended for the
use of the addressees named above. If you are not the intended recipient of
this e-mail, you are hereby notified that you must not disseminate, copy or
take any action in respect of any information contained in it. If you have
received this e-mail in error, please notify the sender immediately by e-mail
and immediately destroy this e-mail and its attachments.
-------------------------------------------------------------------
List admin: http://cool.haxx.se/list/listinfo/curl-library
Etiquette: http://curl.haxx.se/mail/etiquette.html
