sannidhi09 commented on a change in pull request #105:
URL:
https://github.com/apache/airavata-custos-portal/pull/105#discussion_r668776774
##########
File path: src/lib/components/pages/TenantNewEntity.vue
##########
@@ -1,11 +1,22 @@
<template>
- <TenantHome title="New Entity" :breadcrumb-links="breadcrumbLinks"
:errors="errors">
+ <TenantHome :title="this.parentId?'New Child Entity':'New Entity'"
:breadcrumb-links="breadcrumbLinks" :errors="errors">
Review comment:
I understand that, but all the computed functions are stored in the
cache. `title` is used at only one place unlike `parentId`, making `title` as a
computed function will consume cache moreover it has only 2 options.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
