sannidhi09 commented on a change in pull request #105:
URL: 
https://github.com/apache/airavata-custos-portal/pull/105#discussion_r668790484



##########
File path: src/lib/store/modules/entity.store.js
##########
@@ -55,9 +55,9 @@ const actions = {
             ext: entity.ext
         });
     },
-    async createEntity(obj, {clientId, entityId, name, description, type, 
ownerId, fullText, binaryData}) {
-        return await custosService.entities.createEntity({

Review comment:
       The parameter for Dispatch is `Object` and inside the dispatch, we are 
creating another Object based on the parameter object more like `...` spread 
operation. If the passed object doesn't have `parentId` it will automatically 
assign to `undefined` thus our functionality in both cases won't effect.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to