dinukadesilva commented on a change in pull request #105:
URL:
https://github.com/apache/airavata-custos-portal/pull/105#discussion_r669210991
##########
File path: src/lib/components/pages/TenantEntities.vue
##########
@@ -89,7 +63,12 @@ export default {
return this.$route.params.clientId;
},
entities() {
- return this.$store.getters["entity/getEntities"]({clientId:
this.clientId, ownerId: this.currentUsername})
Review comment:
You could use "allEntities" here
##########
File path: src/lib/store/modules/entity.store.js
##########
@@ -55,9 +55,9 @@ const actions = {
ext: entity.ext
});
},
- async createEntity(obj, {clientId, entityId, name, description, type,
ownerId, fullText, binaryData}) {
- return await custosService.entities.createEntity({
Review comment:
Krishna. The concern is that EMC portal need to have this return even
though it's not relevant to custos portal much
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
