> -int
> -main(argc, argv)
> -   int argc;
> -   char *argv[];
> +int main(int argc, char **argv)

>>> Why not use -std=gnu89?

Hi Evgeny,

Thanks for the feedback. 
-std=gnu89 works, but it effectively locks the code to old-style. Updating to 
ANSI-style prototypes ensures builds without relying additional flags. 
It also improves readability for new contributors. Also, aligns with similar 
patches already merged upstream. (cce2ffd374e2ab4507cb973c74348cd1be4d106e, 
354ad78567031edb3c4e70a49ed78a3454a6600f and more)

Using gnu89 would just mask the issue for now, while this change makes the code 
build cleanly with modern GCC versions.

Thanks & regardsĀ 
Thirumalai Nagalingam


Reply via email to