On Oct 30 20:49, Mark Geisert wrote:
> [...]
> Thanks for looking into this issue. Our Cygwin coding conventions specify
> that function names should be at the left margin. So...
>
> int
> main(int argc, char **argv)
> {
> ...
> }
>
> I've not patched the testsuite before so I'm unsure if the same submission
> format applies here as applies to Cygwin DLL patches.
>
Just FTR:
For historical reasons(*), the tests within testsuite/winsup.api are not
actually using Cygwin or GNU coding style, rather a bastardized version
of BSD and GNU style, freely mixed and shaken.
Cygwin style is mostly GNU style with changes only in the comment style,
IIRC. BSD sources in regex and libc subdirs are taken verbatim in terms
of style, even if tweaked.
Diversion from style are often historical as well or simple neglect.
Ideally, patches should use the coding style used by the already
existing code. New files should ideally use Cygwin/GNU-coding style.
Corinna
(*) The base of this testsuite are the ltp tests from SGI.
