Hi,

Thanks for the suggestion, Mark ([email protected]<mailto:[email protected]>).
Thank you for your feedback on the coding conventions. I have incorporated your 
comments and prepared the V2 patch accordingly. Kindly disregard the earlier 
patch submission.

For ease of review, I have included the patch inline below. Additionally, the 
patch file generated using git format-patch -1 is attached as file.
Due to internal constraints, we are not currently using git send-email. 
However, this submission method has worked successfully for previous patches 
sent to the mailing list.

Thanks & regards
Thirumalai Nagalingam

=====
In-line patch:

diff --git a/winsup/testsuite/winsup.api/shmtest.c 
b/winsup/testsuite/winsup.api/shmtest.c
index e0b7acf7d..fc544c5fb 100644
--- a/winsup/testsuite/winsup.api/shmtest.c
+++ b/winsup/testsuite/winsup.api/shmtest.c
@@ -75,9 +75,7 @@ key_t    shmkey;
size_t  pgsize;
 int
-main(argc, argv)
-              int argc;
-              char *argv[];
+main(int argc, char **argv)
{
               struct sigaction sa;
               struct shmid_ds s_ds;
@@ -178,8 +176,7 @@ main(argc, argv)
}
 void
-sigsys_handler(signo)
-              int signo;
+sigsys_handler(int signo)
{
                tst_brkm (TBROK, cleanup,
@@ -187,8 +184,7 @@ sigsys_handler(signo)
}
 void
-sigchld_handler(signo)
-              int signo;
+sigchld_handler(int signo)
{
               struct shmid_ds s_ds;
               int cstatus;
@@ -235,9 +231,7 @@ cleanup()
}
 void
-print_shmid_ds(sp, mode)
-              struct shmid_ds *sp;
-              mode_t mode;
+print_shmid_ds(struct shmid_ds *sp, mode_t mode)
{
               uid_t uid = geteuid();
               gid_t gid = getegid();
===

Attachment: 0001-Cygwin-testsuite-fixes-for-compatibility-with-GCC-15.patch
Description: 0001-Cygwin-testsuite-fixes-for-compatibility-with-GCC-15.patch

Reply via email to