On Feb 20, 2009, at 3:51 AM, Dag Sverre Seljebotn wrote:

> Robert Bradshaw wrote:
>> On Feb 20, 2009, at 3:00 AM, Michael Abshoff wrote:
>>> I have to get 3.3.rc3 out the door and will take your patch later
>>> today
>>> and see of I can figure out what the problem is.
>>
>> Here's the log. (I made it print rather than raise an error). I'm
>> going to try and make it print the source file as well as line.
>
> Hehe, not much use without :-)

Full log at http://trac.sagemath.org/sage_trac/ticket/4987  
Fortunately, lots are the same error over and over. BTW, I don't know  
if printing them out like this could simplify a lot of your manual  
exception handling code.

>> Too many decrefs on line 4775, reference acquired on lines []
>
> Be especially careful that errors like this may easily come from  
> missing
> GOTREFs rather than a refcount error. I don't know whether I have
> GOTREF/GIVEREF everywhere they are needed, just that they are  
> everywhere
> were needed within what we have coverage for.

Yep. Either way, we should track them down.

>> NULL argument on line 4760
>
> Furthermore, if this is a GOTREF or GIVEREF, it may be that the  
> refnanny
> part should be altered to XGOTREF/XGIVEREF for that situation.

Yeah, it could be the case.

>> References leaked:
>>    Acquired on lines: 1048, 1114
>>    Acquired on lines: 1049, 1115
>>    Acquired on lines: 1050, 1116
>
> This kind of output could be clearer, but it means that three  
> different
> objects were leaked in the function, each of which were incref-ed or
> gotref-ed two times.

Thanks for the explanation.

- Robert
_______________________________________________
Cython-dev mailing list
[email protected]
http://codespeak.net/mailman/listinfo/cython-dev

Reply via email to