Robert Bradshaw wrote: > On Feb 20, 2009, at 3:51 AM, Dag Sverre Seljebotn wrote: > >> Robert Bradshaw wrote: >>> On Feb 20, 2009, at 3:00 AM, Michael Abshoff wrote: >>>> I have to get 3.3.rc3 out the door and will take your patch later >>>> today >>>> and see of I can figure out what the problem is. >>> Here's the log. (I made it print rather than raise an error). I'm >>> going to try and make it print the source file as well as line. >> Hehe, not much use without :-) > > Full log at http://trac.sagemath.org/sage_trac/ticket/4987 > Fortunately, lots are the same error over and over. BTW, I don't know > if printing them out like this could simplify a lot of your manual > exception handling code.
Not really. One may enter refnanny.pyx during exception cleanup while an exception is set, and then refnanny.pyx goes on to doing lots of Python operations -- the first error flag check within refnanny.pyx will cause the execution stack to pop even if there wasn't a problem within refnanny.pyx itself. It could however simplify the four lines at the end of every function in Cython-generated C code. Personally I prefer to have the testcases listed as "failed" when run from runtests.py (and even be able to flag refcount errors as expected in doctests, if we ever need that), but I don't have a strong opinion either way. -- Dag Sverre _______________________________________________ Cython-dev mailing list [email protected] http://codespeak.net/mailman/listinfo/cython-dev
