On Sat, 8 Nov 2008, Salvatore Insalaco wrote: > 2008/11/8 Ganesh Sittampalam <[EMAIL PROTECTED]>: >> On Sat, 8 Nov 2008, Salvatore Insalaco wrote: >> >>> I think that the change I made (BL.readFile -> fmap (BL.fromChunks . >>> (:[])) B.readFile) is O(1), so it should not affect performance (Don, >>> is it right?). >> >> Much as I dislike conditional compilation, I think using it here would make >> sense, so that we know that we can change it back by dropping the >> conditional code at some point in the (fairly distant) future when we drop >> support for things that old. > > I believe that this change makes strictness semantics more explicit, and > has no performance penalties. If Don doesn't tell us anyway, I think > that it's better to keep it with B.readFile.
The current data pipeline is file =[lazy]=> decompress =[lazy]=> strictify Your change is to file =[strict]=> decompress =[lazy]=> strictify I don't think that's a good idea in general, because the entire file now needs to be read into memory before decompression, whereas before it would stream nicely. As you say, Don (or Duncan) are best placed to comment further. Ganesh _______________________________________________ darcs-users mailing list [email protected] http://lists.osuosl.org/mailman/listinfo/darcs-users
