kirby81: > ---- Patch description ---- > BL.readFile is not strict enough, and it actually leaves the file > descriptor opened. This should not happen, and probably it's a bug > with older bytestrings (the one shipped with ghc 6.8.x). > This causes issues on Windows, where an opened file cannot be deleted. > Using strict bytestring readFile, and then converting them to lazy > bytestring (should be O(1)) fix the problem. > -------- > > This patch should fix the Windows buildbot breakage. > I recall that early (0.9.0.x, shipped with GHC 6.8.3) bytestring had > some issue with lazy readFile behaviour, and we cannot easily request > Windows users to update, as new bytestring (0.9.1.3) on hackage > requires to build a more recent regex-posix, that doesn't build easily > on Windows (requires mingw because it uses shell scripts).
Oh, you mean if you upgraded bytestring, you'd probably want to rebuild regex-*. > I think that the change I made (BL.readFile -> fmap (BL.fromChunks . > (:[])) B.readFile) is O(1), so it should not affect performance (Don, > is it right?). > > Salvatore yes, that's right, Salvatore. _______________________________________________ darcs-users mailing list [email protected] http://lists.osuosl.org/mailman/listinfo/darcs-users
