On Wed, Apr 22, 2009 at 11:55 PM, Eric Kow <[email protected]> wrote: > On Wed, Apr 22, 2009 at 17:33:50 +0400, Dmitry Kurochkin wrote: >> This behavior is similar to svn and is useful to me sometimes. > > Could you give some examples of how this would work in practice, i.e. > some use cases? Is this for all descriptions that get edited with an > external editor?
This is for all files edited with edit_file. At the moment it is used for send and record descriptions. We check file content (read all content using strict ByteString) before and after the edit. If content did not change: > File content did not change. Continue anyway? is printed. If user answers 'n' we exit with (ExitFailure 1) otherwise continue as usual. Descriptions should not be very big. So I do not think reading file content would harm performance or memory usage significantly. Use case: I do darcs send --edit-description. While editing the description I recall that I forgot something (this happens quite often to me). I type :q! in vim to exit without saving and answer 'n' to abort. IIRC there was a bug requesting this feature. But I could not find it. Or was it a mail on ML? Regards, Dmitry > > It sounds like like would be useful indeed. > > -- > Eric Kow <http://www.nltg.brighton.ac.uk/home/Eric.Kow> > PGP Key ID: 08AC04F9 > > -----BEGIN PGP SIGNATURE----- > Version: GnuPG v1.4.9 (GNU/Linux) > > iEYEARECAAYFAknvdiwACgkQBUrOwgisBPmzmACcCSMZZ5fA6nCAG29lBCJHy6Sl > mmMAn3YcbGuerS4g6t5znHe585bf83kE > =0TJI > -----END PGP SIGNATURE----- > > _______________________________________________ darcs-users mailing list [email protected] http://lists.osuosl.org/mailman/listinfo/darcs-users
