On Thu, Apr 23, 2009 at 2:15 PM, Eric Kow <[email protected]> wrote: >> This is for all files edited with edit_file. At the moment it is used >> for send and record descriptions. > > ... > >> Descriptions should not be very big. So I do not think reading file >> content would harm performance or memory usage significantly. >> >> Use case: I do darcs send --edit-description. While editing the >> description I recall that I forgot something (this happens quite often >> to me). I type :q! in vim to exit without saving and answer 'n' to >> abort. > > Thanks! I'm going to apply this and see if anybody from darcs-users > complains. > >> IIRC there was a bug requesting this feature. But I could not find it. >> Or was it a mail on ML? > > Is this the discussion you were thinking of? > http://lists.osuosl.org/pipermail/darcs-users/2008-November/015848.html
Yes. The patch resolves issue1186. > > Maybe we need to revisit the confirmations there? Perhaps we should. Anyway I did not want to add additional question in darcs send. IMHO it is not useful. Usually I realize that I do not want to send while editing description - exiting without saving is just fine in this case. Of course sometimes I want to cancel after saving I edited the description. But that is a rare case. And no amount of additional confirmations is going to save you from been inattentive. Regards, Dmitry > > Cheers, > > -- > Eric Kow <http://www.nltg.brighton.ac.uk/home/Eric.Kow> > PGP Key ID: 08AC04F9 > _______________________________________________ darcs-users mailing list [email protected] http://lists.osuosl.org/mailman/listinfo/darcs-users
