Hi Benedikt. I have reviewed the patches and they look good.
On Fri, Apr 24, 2009 at 3:37 AM, Benedikt Schmidt <[email protected]> wrote: > The first patch shortens the recently added comment describing why > read_repo is called twice. > > The second patch is a performance optimization to speed up patch > parsing and make_filename. The old version used naive list code > to parse the date (lots of drop, take, and read). Just using the > ByteString versions where take and drop are O(1) made the code > fast enough to not show up at the top of profiling report. Why not putting this in the patch description? > > Before: darcs changes >/dev/null (real 0m1.039s/user 0m0.978s/sys 0m0.053s) > =======: > COST CENTRE MODULE %time %alloc > > parseDate OldDate 32.6 31.2 > friendly_d Darcs.Patch.Info 14.0 9.7 > hPrintPrintable Printer 8.1 26.6 > escapePrinter Darcs.ColorPrinter 5.8 2.1 > escape Darcs.ColorPrinter 5.8 4.0 > n_digits OldDate 5.8 3.1 > > After: darcs changes >/dev/null (real 0m0.766s/user 0m0.702s/sys 0m0.054s) > ====== > COST CENTRE MODULE %time %alloc > hPrintPrintable Printer 20.0 37.5 > friendly_d Darcs.Patch.Info 18.5 13.6 > escape Darcs.ColorPrinter 12.3 5.7 > escapePrinter Darcs.ColorPrinter 9.2 3.0 > isPrintableAscii Darcs.ColorPrinter 6.2 0.0 > gzReadFilePS ByteStringUtils 4.6 0.6 > n_digits OldDate 3.1 4.4 > iso8601_date OldDate 3.1 0.1 > readPatchDate Darcs.Patch.Info 3.1 0.9 Nice results! Regards, Dmitry > > Fri Apr 24 01:24:41 CEST 2009 Benedikt Schmidt <[email protected]> > * shorten comment > > Fri Apr 24 01:27:04 CEST 2009 Benedikt Schmidt <[email protected]> > * change parseData in OldDate and IsoDate to use ByteStrings > > > _______________________________________________ > darcs-users mailing list > [email protected] > http://lists.osuosl.org/mailman/listinfo/darcs-users > > _______________________________________________ darcs-users mailing list [email protected] http://lists.osuosl.org/mailman/listinfo/darcs-users
