On Thu, Apr 23, 2009 at 16:37:57 -0700, Benedikt Schmidt wrote: > The first patch shortens the recently added comment describing why > read_repo is called twice.
I've applied this one, and not the other because it was superseded by a revised version you sent. Hooray for concision (which to my pleasant surprise is actually a word in English) shorten comment --------------- > Benedikt Schmidt <[email protected]>**20090423232441 > Ignore-this: 7ef97ce4684b5fcf0d0df6672aa44bcd > ] hunk ./src/Darcs/Commands/Changes.lhs 129 > putStrLn $ "Changes to "++unwords filez++":\n" > debugMessage "About to print the changes..." > let printers = if XMLOutput `elem` opts then simplePrinters else > fancyPrinters > - -- Read patchset again instead of using patches from > - -- above. filtered_changes goes through _all_ the patches > - -- sequentially, but they can't be discarded by the GC if > - -- changelog needs them later on. Note that changelog uses > - -- the patchset only if the number option is used, so ps > - -- is not evaluated if the flag is not present. > - ps <- read_repo repository > + ps <- read_repo repository -- read repo again to prevent holding > onto > + -- values forced by filtered_changes > putDocLnWith printers $ changelog opts ps $ filtered_changes > patches > where maybe_reverse (xs,b,c) = if Reverse `elem` opts > then (reverse xs, b, c) -- Eric Kow <http://www.nltg.brighton.ac.uk/home/Eric.Kow> PGP Key ID: 08AC04F9
signature.asc
Description: Digital signature
_______________________________________________ darcs-users mailing list [email protected] http://lists.osuosl.org/mailman/listinfo/darcs-users
