Hi Dimitry,
On Apr 24, 2009, at 10:10 AM, Dmitry Kurochkin wrote:
I have reviewed the patches and they look good.
Thanks for the quick review!
On Fri, Apr 24, 2009 at 3:37 AM, Benedikt Schmidt
<[email protected]> wrote:
The first patch shortens the recently added comment describing why
read_repo is called twice.
The second patch is a performance optimization to speed up patch
parsing and make_filename. The old version used naive list code
to parse the date (lots of drop, take, and read). Just using the
ByteString versions where take and drop are O(1) made the code
fast enough to not show up at the top of profiling report.
Why not putting this in the patch description?
I will change the patch description for the second patch and send a
new version.
Best,
Benedikt
_______________________________________________
darcs-users mailing list
[email protected]
http://lists.osuosl.org/mailman/listinfo/darcs-users
