On Fri, Mar 17, 2017 at 12:30 AM, Uwe Müssel <uwe_mues...@web.de> wrote: > 2017-03-16 21:50 GMT+01:00 Roman Lebedev <lebedev...@gmail.com>: >> >> Now, the important question: do you know if that code is noticeably >> different from >> the vanilla libraw/rawtherapee version? Does it have any >> behavior-changing changes? >> Like, producing different output for the same raw? > > > The main diffrerence between this code and the libraw/rawtherapee code is > in reading the file. Libraw does it with fseek and fread into a local > "small" buffer. In a first version I replaced this by memcpy operations. Now > I use simple input.getData(...).
> The decompression algorithm itself is untouched. I even do not know how it > is working in detail. I expect the raw the be equal. Ok, good. > There is some more cleanup to be done, e.g. remove obsolete fields. Then please don't do that just yet. >> Oh, and, please apply clang-format to decompressors/FujiDecompressor.* >> and install clang-format git hook, so that the formatting is uniform. > I will do this on the next commit. It probably makes sense to squash it into that first commit. I think it may make sense for me to merge your work into a separate branch (raf-compressed) of the repo first. Did you try building rawspeed on it's own, or only as part of darktable? Does it actually compile with all the current warning flags? If not i'd just disable -Werror for now. Roman. ___________________________________________________________________________ darktable developer mailing list to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org
