Hi

As for the uninitialized values, they are expected when the raw data is at
the end of the file, a larger than needed buffer is allocated for reading
the file into memory.

When the bits are unpacked ahead of time, it is done on 12 bytes at the
time, at most 3 bytes before they are needed. This means that you can
potentially be 15 bytes ahead of the decoder, which is why a buffer of +16
bytes is allocated.

(this behaviour isn't actually needed as much since a recent rewrite, and I
have considered sacrificing a little speed to avoid this)

The "invalid" reads are unaligned integer reads, which isn't a problem on
x86. Again they are expected (we are casting a byte array to int at
arbitrary positions), but a special case could be made for non-x86, which
assembles an int from individual bytes.


Regards, Klaus Post

http://www.klauspost.com



On Sat, Dec 8, 2012 at 7:58 AM, johannes hanika <[email protected]> wrote:

> cool!
>
> On Sat, Dec 8, 2012 at 7:49 PM, B.W.H. van Beest <[email protected]> wrote:
> > Just to let you guys know:    I installed openSuSe 12.2, ensured it was
> > 64 bits indeed.
> > The Darktable executable is 64bit, sees all the 24GB of memory and is
> > running the way it should.
> > Thanks for your help.
> >
> >
> > Regards,
> > Bertwim
> >
> >
> >
> > On 12/07/2012 02:21 PM, Ulrich Pegelow wrote:
> >> Another topic - not directly related - comes up here. Knowing that the
> >> system is in fact 32-bit, some of the default settings in darktablerc
> >> don't make sense.
> >>
> >> worker_threads should be 1 but is 2
> >> cache_memory should be something like 200MB but it is 500MB
> >>
> >> I think we have different places which interact with a newly
> darktablerc:
> >>
> >> dt_configure_defaults() defined in darktable.c and called from conf.h
> >> dt_ctl_settings_default() defined in control.c and called from
> darktable.c
> >>
> >> The settings for cache_memory as in dt_configure_defaults() should
> >> certainly read "200u << 20". That would be easy to fix but there are
> >> more issues.
> >>
> >> I have to admit I don't understand the way of working :) Maybe someone
> >> else could have a look?
> >>
> >> Ulrich
> >>
> >> Am 07.12.2012 09:39, schrieb B.W.H. van Beest:
> >>> Johannes,
> >>>
> >>> As far as I can tell, all is reasonable. I have included the output of
> >>> the command as an attachment.
> >>> Also I included the new darktablerc file that was created after I
> >>> deleted the previous one.
> >>>
> >>> Finally, I ran   "valgrind darktable . |& tee valgrind.out"
> >>>
> >>> There are quite a few suspicious error messages in that file. Can you
> >>> make sense of that?
> >>>
> >>> Regards,
> >>> Bertwim
> >>>
> >>
> ------------------------------------------------------------------------------
> >> LogMeIn Rescue: Anywhere, Anytime Remote support for IT. Free Trial
> >> Remotely access PCs and mobile devices and provide instant support
> >> Improve your efficiency, and focus on delivering more value-add services
> >> Discover what IT Professionals Know. Rescue delivers
> >> http://p.sf.net/sfu/logmein_12329d2d
> >> _______________________________________________
> >> darktable-devel mailing list
> >> [email protected]
> >> https://lists.sourceforge.net/lists/listinfo/darktable-devel
> >>
> >
> >
> >
> ------------------------------------------------------------------------------
> > LogMeIn Rescue: Anywhere, Anytime Remote support for IT. Free Trial
> > Remotely access PCs and mobile devices and provide instant support
> > Improve your efficiency, and focus on delivering more value-add services
> > Discover what IT Professionals Know. Rescue delivers
> > http://p.sf.net/sfu/logmein_12329d2d
> > _______________________________________________
> > darktable-devel mailing list
> > [email protected]
> > https://lists.sourceforge.net/lists/listinfo/darktable-devel
>
>
> ------------------------------------------------------------------------------
> LogMeIn Rescue: Anywhere, Anytime Remote support for IT. Free Trial
> Remotely access PCs and mobile devices and provide instant support
> Improve your efficiency, and focus on delivering more value-add services
> Discover what IT Professionals Know. Rescue delivers
> http://p.sf.net/sfu/logmein_12329d2d
> _______________________________________________
> darktable-devel mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/darktable-devel
>
------------------------------------------------------------------------------
LogMeIn Rescue: Anywhere, Anytime Remote support for IT. Free Trial
Remotely access PCs and mobile devices and provide instant support
Improve your efficiency, and focus on delivering more value-add services
Discover what IT Professionals Know. Rescue delivers
http://p.sf.net/sfu/logmein_12329d2d
_______________________________________________
darktable-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/darktable-devel

Reply via email to