Johanes, I might be to blame for the "not convert history on import but later"
the UI philosophy we were going from was that a LR import was a
replacement for the default settings for new images...
i.e history is imported when you enter darkroom for the first time
and IIUC the button was removed in current version (but I my be wrong
on that one...)
On Sat, Jan 26, 2013 at 9:04 PM, johannes hanika <hana...@gmail.com> wrote:
> On Sun, Jan 27, 2013 at 2:41 AM, Pascal Obry <pas...@obry.net> wrote:
>>
>> Johannes,
>>
>>> cool, thanks for putting it in a branch :)
>>
>> I have pushed a minor correction yesterday. I have also tested more on
>> my side by importing some directories with Lr .xmp. All went fine. It
>> would be nice though if someone with some Lr .xmp could also test this
>> feature.
>
> yeah, about that.. can you pastebin an example maybe? without it i can
> only read code.
>
> but i have a question about workflow and buttons. why the buttons? you
> are reading the xmp during import, to get the tags, right? why not
> convert the history at this stage, too? this way you could even
> manually go back to it via `lighttable->load xmp' maybe?
>
> i guess that should be relatively straight forward if you're
> constructing the params structs already (see src/common/exif.cc:~1300
> how to inject it into the database then). this way will also give you
> the updated module parameters via legacy_params() in case the
> lightroom converter lags behind the module version.
>
> there was some talk about that earlier, maybe this was the plan
> anyways? i might be missing a workflow point about buttons.. in my
> mind the best button is the one i don't ever have to push and thus
> doesn't exist :)
>
> oh, one style/programming thing:
>
> strcpy(message, imported);
> strcat(message, " ");
> if (n_import==1)
> strcat(message, _("has been imported"));
> else
> strcat(message, _("have been imported"));
>
> could be written more concisely using snprintf() and ngettext() for
> translated plural forms depending on a number. the above will be next
> to impossible to translate (imagine a language where you need to
> change order of the number and the rest of the sentence).
>
> cheers,
> jo
>
> ------------------------------------------------------------------------------
> Master Visual Studio, SharePoint, SQL, ASP.NET, C# 2012, HTML5, CSS,
> MVC, Windows 8 Apps, JavaScript and much more. Keep your skills current
> with LearnDevNow - 3,200 step-by-step video tutorials by Microsoft
> MVPs and experts. ON SALE this month only -- learn more at:
> http://p.sf.net/sfu/learnnow-d2d
> _______________________________________________
> darktable-devel mailing list
> darktable-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/darktable-devel
------------------------------------------------------------------------------
Master Visual Studio, SharePoint, SQL, ASP.NET, C# 2012, HTML5, CSS,
MVC, Windows 8 Apps, JavaScript and much more. Keep your skills current
with LearnDevNow - 3,200 step-by-step video tutorials by Microsoft
MVPs and experts. ON SALE this month only -- learn more at:
http://p.sf.net/sfu/learnnow-d2d
_______________________________________________
darktable-devel mailing list
darktable-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/darktable-devel
