On Sun, Jan 27, 2013 at 1:34 PM, Pascal Obry <pas...@obry.net> wrote:
>
> Johannes,
>
>> code design wise i find the idea of a single entry point interesting
>> (now we have two). wrt speed, if you don't use embedded jpg
>> thumbnails, the thumbnail creation process will load the auto-apply
>> presets asynchronously in the background, so i would expect the same
>> (hopefully marginal) impact in this case.
>
> No strong opinion either and frankly I really don't know what would be
> best. I have no enough knowledge about Dt to take the right choice here.
> My thinking is that if I do the conversion at import time I get the lr
> converted iop before any other dev settings (all the defaults iop for
> the camera for example), but is that a problem?
the auto-apply thing will be slipped under all the other history
items, so it will come before either way (needs to do that to handle
legacy history stacks, due to the way auto apply was done before..).
and two entry points into that code vs one also still seems to be
relatively easy to maintain.
>>>> oh, one style/programming thing:
>>>>
>>>> strcpy(message, imported);
>>>> strcat(message, " ");
>>>> if (n_import==1)
>>>> strcat(message, _("has been imported"));
>>>> else
>>>> strcat(message, _("have been imported"));
>>>>
>>>> could be written more concisely using snprintf() and ngettext() for
>>>> translated plural forms depending on a number. the above will be next
>>>> to impossible to translate (imagine a language where you need to
>>>> change order of the number and the rest of the sentence).
>
> Sure, will fix that tomorrow.
no worries.
-jo
> Pascal.
>
> --
> Pascal Obry / Magny Les Hameaux (78)
>
> The best way to travel is by means of imagination
>
> http://v2p.fr.eu.org
> http://www.obry.net
>
> gpg --keyserver keys.gnupg.net --recv-key F949BD3B
------------------------------------------------------------------------------
Master Visual Studio, SharePoint, SQL, ASP.NET, C# 2012, HTML5, CSS,
MVC, Windows 8 Apps, JavaScript and much more. Keep your skills current
with LearnDevNow - 3,200 step-by-step video tutorials by Microsoft
MVPs and experts. ON SALE this month only -- learn more at:
http://p.sf.net/sfu/learnnow-d2d
_______________________________________________
darktable-devel mailing list
darktable-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/darktable-devel
