On Sun, Jan 27, 2013 at 9:42 AM, Pascal Obry <pas...@obry.net> wrote:
> Sorry for top posting.
>
> I don't understand why you are talking about a button. There is no button at
> all, in fact my patch removes a button.
i can see that, but i remember you said it's a slower workflow that
way, missed all the discussions and wondered if there was anything
interesting to know about that.
> About importings the iop during
> import, this is not needed at this stage, it will slow down import for no
> gain. Also I feel that it is better to add lr iop after defaults ones. No?
no idea what makes sense in this case (i.e. if you convert a
tonecurve, will lightroom apply that in gamma-corrected space or in
linear.. so do you want the basecurve or not?).
code design wise i find the idea of a single entry point interesting
(now we have two). wrt speed, if you don't use embedded jpg
thumbnails, the thumbnail creation process will load the auto-apply
presets asynchronously in the background, so i would expect the same
(hopefully marginal) impact in this case.
-jo
>
> Pascal.
>
> Pascal Obry / Magny les Hameaux
>
> Le 26 janv. 2013 21:04, "johannes hanika" <hana...@gmail.com> a écrit :
>
>> On Sun, Jan 27, 2013 at 2:41 AM, Pascal Obry <pas...@obry.net> wrote:
>> >
>> > Johannes,
>> >
>> >> cool, thanks for putting it in a branch :)
>> >
>> > I have pushed a minor correction yesterday. I have also tested more on
>> > my side by importing some directories with Lr .xmp. All went fine. It
>> > would be nice though if someone with some Lr .xmp could also test this
>> > feature.
>>
>> yeah, about that.. can you pastebin an example maybe? without it i can
>> only read code.
>>
>> but i have a question about workflow and buttons. why the buttons? you
>> are reading the xmp during import, to get the tags, right? why not
>> convert the history at this stage, too? this way you could even
>> manually go back to it via `lighttable->load xmp' maybe?
>>
>> i guess that should be relatively straight forward if you're
>> constructing the params structs already (see src/common/exif.cc:~1300
>> how to inject it into the database then). this way will also give you
>> the updated module parameters via legacy_params() in case the
>> lightroom converter lags behind the module version.
>>
>> there was some talk about that earlier, maybe this was the plan
>> anyways? i might be missing a workflow point about buttons.. in my
>> mind the best button is the one i don't ever have to push and thus
>> doesn't exist :)
>>
>> oh, one style/programming thing:
>>
>> strcpy(message, imported);
>> strcat(message, " ");
>> if (n_import==1)
>> strcat(message, _("has been imported"));
>> else
>> strcat(message, _("have been imported"));
>>
>> could be written more concisely using snprintf() and ngettext() for
>> translated plural forms depending on a number. the above will be next
>> to impossible to translate (imagine a language where you need to
>> change order of the number and the rest of the sentence).
>>
>> cheers,
>> jo
------------------------------------------------------------------------------
Master Visual Studio, SharePoint, SQL, ASP.NET, C# 2012, HTML5, CSS,
MVC, Windows 8 Apps, JavaScript and much more. Keep your skills current
with LearnDevNow - 3,200 step-by-step video tutorials by Microsoft
MVPs and experts. ON SALE this month only -- learn more at:
http://p.sf.net/sfu/learnnow-d2d
_______________________________________________
darktable-devel mailing list
darktable-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/darktable-devel
