> slr-tamron.xml: <model>Tamron 17-50mm f/2.8 XR Di II LD</model>
>
> Exif.PentaxDng.LensType Byte 4 Tamron AF
> 17-50mm F2.8 XR Di-II LD (Model A16)
>
> So the problem seems to be the Model A16 suffix :(
>
> So looking into the Exiv2 sources:
>
> { 0x04e6, "Tamron SP AF 17-50mm F2.8 XR Di II" },
> { 0x07e6, "Tamron AF 17-50mm F2.8 XR Di-II LD (Model A16)" },
>
In this particular case: are these different lenses? Or are there just
two different names for one single lens?
> So to be honest I'm not sure how to proceed with this.... I'm tempted
> to think this should be resolved on lensfun's end with aliases instead
> of fuzzy matching....
>
> The temporary workaround would be to create a local """alias""" by
> copying the lensfun entry with a different name.
The problem I see is that an exact lens name search will never work.
AFAIK the lens name is not directly stored in EXIF data but just a lens
ID. This lens ID is resolved by the EXIF reader to a human readable
name. So the exact name highly depends on the underlying EXIF library.
I don't think it's a good solution to introduce aliases in the lensfun
database. This would end up in adding aliases for every single exif
library. Ok, currently most open source projects use exiv2 but even in
this case, as soon as exiv2 changes some lens names we have to adjust
the database. There will always be lenses that won't exactly match the
name in the database anyway. So from my point of view it should be up to
the application and user interface to finally let the user check if the
preselected lens is correct. An auto selection and correction based on
lens exif data will never work reliably.
For example Darktable could automatically select the correct profile in
it's GUI but the user would have to manually enable the lens correction
tool to apply the changes.
Sebastian
------------------------------------------------------------------------------
Everyone hates slow websites. So do we.
Make your web apps faster with AppDynamics
Download AppDynamics Lite for free today:
http://p.sf.net/sfu/appdyn_d2d_mar
_______________________________________________
darktable-devel mailing list
darktable-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/darktable-devel
