Am 17.03.2013 12:22, schrieb Ulrich Pegelow: >> >> The score field in the lens search result struct is documented in the >> manual. So I think it is supposed to be used. The only missing thing is >> a specification of the value range. >> >> Why not giving it a try? Maybe with a conservative threshold first... It >> can only improve the automagic matching in Darktable. >> > > First feedback: doesn't work very well, unfortunately. The biggest > problems are the gaps in lensfun's database when it comes to recent lenses. > > Example: my Canon EF 70-200 2.8L II is not in. The loose search will > return the correction parameters of the Mark I version of that lens with > a score of 96. Both lenses are quite different! > > I could increase the score threshold to 100, but then what does it mean > concerning the original issue of the Tamron 17-50 and its different names? >
I see... that won't work with the Canon lenses only differing by II or III :( Ok, what we have so far: Strict search won't work as lens names are not standardized and differ in some parts of the name. See Tamron 17-50. Fuzzy search won't work as lens names sometimes only differ by one last letter. See Canon 70-200 I...III So none of the search algorithms works reliably and even modifying the algorithms would not help. It's just a conflict of requirements. Or do you see any possible improvements in the algorithms? Your proposal was to add aliases in the database. But this will be quite specific to the library used by applications and fill the database with highly redundant information. Not a good solution IMO. Maybe we should start creating an alias.xml like it was proposed somewhere in this thread. Then we will see how many lenses are actually concerned and can better decide how to solve this in a clean way. I could imagine to use such an alias.xml if there are no more than 20 lenses in it. But afterwards it will become to messy to maintain the information across different locations. BTW: regarding the Tamron 17-50 lens. Exiv2 has two entries and IDs for this lens... so it seems like these are really different versions, but maybe with the same optical characteristics. Sebastian ------------------------------------------------------------------------------ Everyone hates slow websites. So do we. Make your web apps faster with AppDynamics Download AppDynamics Lite for free today: http://p.sf.net/sfu/appdyn_d2d_mar _______________________________________________ darktable-devel mailing list darktable-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/darktable-devel
