Am 16.03.2013 21:40, schrieb Sebastian Kraft: > Am 16.03.2013 16:34, schrieb Ulrich Pegelow: >> Am 16.03.2013 15:23, schrieb Sebastian Kraft: >>> Am 16.03.2013 15:18, schrieb Ulrich Pegelow: >>>> >>>> Is the score value documented anywhere? What would be a good threshold >>>> to accept or refuse a match? >>>> >>> >>> Unfortunately not :( I just found out that this exists a few weeks ago. >>> You can compile the tfun.cpp example code and try a search with several >>> lens names supplied by commandline arguments. A perfect match is around >>> 80 points. The Tamron 17-50 lens with the "(model 16)" part yields 67 >>> points. So maybe a threshold at 50 points should work? >>> >> >> I am wondering if this interface is stable enough and supposed to be >> used externally? If not we might get into trouble. >> > > The score field in the lens search result struct is documented in the > manual. So I think it is supposed to be used. The only missing thing is > a specification of the value range. > > Why not giving it a try? Maybe with a conservative threshold first... It > can only improve the automagic matching in Darktable. >
First feedback: doesn't work very well, unfortunately. The biggest problems are the gaps in lensfun's database when it comes to recent lenses. Example: my Canon EF 70-200 2.8L II is not in. The loose search will return the correction parameters of the Mark I version of that lens with a score of 96. Both lenses are quite different! I could increase the score threshold to 100, but then what does it mean concerning the original issue of the Tamron 17-50 and its different names? I think the loose search would be a good idea if lensfun's database is halfways complete. Maybe the project should start a "close the gap" initiative. Ulrich ------------------------------------------------------------------------------ Everyone hates slow websites. So do we. Make your web apps faster with AppDynamics Download AppDynamics Lite for free today: http://p.sf.net/sfu/appdyn_d2d_mar _______________________________________________ darktable-devel mailing list darktable-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/darktable-devel
