actually, a generic solution for exporting all XMP metadata in a generic
way would be awesome...

post next release of course since we are in string freeze...


On Fri, Nov 15, 2013 at 12:37 PM, Tobias Ellinghaus <h...@gmx.de> wrote:

> Am Freitag, 15. November 2013, 00:00:35 schrieb Chris Chiappa:
> > I'm interested in this feature for my own workflow and I was able to
> > get some traction just with the trivial patch attached.  A proper
> > implemenation would need more work, but is something like this the
> > type of feature that would likely be acceptable?  Apart from the
> > obvious Xmp.dc.* values, is there other work in this area that would
> > be worth thinking about at the same time?  Thanks!
>
> In general that's ok. However, I just looked over our code and noticed
> that we
> leak some memory when calling dt_metadata_get() in several places, and you
> copied the bug, too.
>
> Please replace
>
> g_list_free(title);
>
> with
>
> g_list_free_full(title, &g_free);
>
> in cases where the returned value is a string. For stars or colorlabels a
> regular g_list_free() is correct.
>
> If there are any more questions feel free to join us in IRC.
>
> Tobias, busy fixing the memleaks :)
>
>
> ------------------------------------------------------------------------------
> DreamFactory - Open Source REST & JSON Services for HTML5 & Native Apps
> OAuth, Users, Roles, SQL, NoSQL, BLOB Storage and External API Access
> Free app hosting. Or install the open source package on any LAMP server.
> Sign up and see examples for AngularJS, jQuery, Sencha Touch and Native!
> http://pubads.g.doubleclick.net/gampad/clk?id=63469471&iu=/4140/ostg.clktrk
> _______________________________________________
> darktable-devel mailing list
> darktable-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/darktable-devel
>
>
------------------------------------------------------------------------------
DreamFactory - Open Source REST & JSON Services for HTML5 & Native Apps
OAuth, Users, Roles, SQL, NoSQL, BLOB Storage and External API Access
Free app hosting. Or install the open source package on any LAMP server.
Sign up and see examples for AngularJS, jQuery, Sencha Touch and Native!
http://pubads.g.doubleclick.net/gampad/clk?id=63469471&iu=/4140/ostg.clktrk
_______________________________________________
darktable-devel mailing list
darktable-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/darktable-devel

Reply via email to