On Fri, Nov 15, 2013 at 12:37:55PM +0100, Tobias Ellinghaus wrote: > > I'm interested in this feature for my own workflow and I was able to > > get some traction just with the trivial patch attached. A proper > > implemenation would need more work, but is something like this the > > type of feature that would likely be acceptable? Apart from the > > obvious Xmp.dc.* values, is there other work in this area that would > > be worth thinking about at the same time? Thanks! > In general that's ok. However, I just looked over our code and noticed that > we > leak some memory when calling dt_metadata_get() in several places, and you > copied the bug, too. OK, I am still struggling with rebasing with git (I seem to have polluted my fork with a lot of extraneous commits), but does this look reasonable otherwise, apart from the whole feature-freeze thing?
https://github.com/CChiappa/darktable/compare/darktable-org:master...master I'm not super familiar with the Xmp schema, ie if it would make sense to try to come up with a more generic way of allowing any Xmp bit to get used in the filename. I realize the current set may even be a bit silly - it's unclear if anyone would actually want to use Xmp.dc.rights in their filename! -- [ ch...@chiappa.net | chris.chia...@oracle.com ] [ http://www.chiappa.net/~chris/ ] ------------------------------------------------------------------------------ DreamFactory - Open Source REST & JSON Services for HTML5 & Native Apps OAuth, Users, Roles, SQL, NoSQL, BLOB Storage and External API Access Free app hosting. Or install the open source package on any LAMP server. Sign up and see examples for AngularJS, jQuery, Sencha Touch and Native! http://pubads.g.doubleclick.net/gampad/clk?id=63469471&iu=/4140/ostg.clktrk _______________________________________________ darktable-devel mailing list darktable-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/darktable-devel
