Am Sonntag, 17. November 2013, 23:26:12 schrieb Chris Chiappa: > On Fri, Nov 15, 2013 at 12:37:55PM +0100, Tobias Ellinghaus wrote: > > > I'm interested in this feature for my own workflow and I was able to > > > get some traction just with the trivial patch attached. A proper > > > implemenation would need more work, but is something like this the > > > type of feature that would likely be acceptable? Apart from the > > > obvious Xmp.dc.* values, is there other work in this area that would > > > be worth thinking about at the same time? Thanks! > > > > In general that's ok. However, I just looked over our code and noticed > > that we leak some memory when calling dt_metadata_get() in several > > places, and you copied the bug, too. > > OK, I am still struggling with rebasing with git (I seem to have > polluted my fork with a lot of extraneous commits), but does this look > reasonable otherwise, apart from the whole feature-freeze thing? > > https://github.com/CChiappa/darktable/compare/darktable-org:master...master > > I'm not super familiar with the Xmp schema, ie if it would make sense > to try to come up with a more generic way of allowing any Xmp bit to > get used in the filename. I realize the current set may even be a bit > silly - it's unclear if anyone would actually want to use > Xmp.dc.rights in their filename!
I haven't tested it but it looks okayish at first sight.
signature.asc
Description: This is a digitally signed message part.
------------------------------------------------------------------------------ Shape the Mobile Experience: Free Subscription Software experts and developers: Be at the forefront of tech innovation. Intel(R) Software Adrenaline delivers strategic insight and game-changing conversations that shape the rapidly evolving mobile landscape. Sign up now. http://pubads.g.doubleclick.net/gampad/clk?id=63431311&iu=/4140/ostg.clktrk
_______________________________________________ darktable-devel mailing list darktable-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/darktable-devel
