>1. Is it ok to update the preset? I suppose so, the old already
>developed images will keep the previous curve.
Since tonecurve [in history] is stored as curve and not as "take curve from
%preset_name",
i would say that it is safe, but *maybe* there is an agreement not to
update presets but add new-ones?

>2. when I put the preset in src/tonecurve.c it does not appears in the
>basecurve iop. Is that expected?
Yes, because src/iop/tonecurve.c != src/iop/basecurve.c
And there is no introspection between iops (yet?)
And probably using basecurve iop preset in tonecurve iop (and reverse)
would result in different results.

>I mean the variable is named
>presets_from_basecurve and I would have expected some cooperation with
>the basecurve iop, no?
Nope.
Why it has such misleading name you should ask author, git blame says
commit aa68da4f

>3. if the tonecurve iop is used with this curve I need to deactivate the
>basecure iop. This is not convenient as I'll need to use multiple
>instance for the tonecure which is far more generic than the basecurve.
What is the question?


On Sat, Jul 19, 2014 at 11:17 PM, Pascal Obry <pas...@obry.net> wrote:

>
> While help Alan to create a base curve for the Nikon D810 I tried the
> new dt-curve-tool with the pictures I used to create the Nikon D800
> curve with the old tool to compare. And the result is lot better with
> the new tool.
>
> Some questions:
>
> 1. Is it ok to update the preset? I suppose so, the old already
> developed images will keep the previous curve.
>
> 2. when I put the preset in src/tonecurve.c it does not appears in the
> basecurve iop. Is that expected? I mean the variable is named
> presets_from_basecurve and I would have expected some cooperation with
> the basecurve iop, no?
>
> 3. if the tonecurve iop is used with this curve I need to deactivate the
> basecure iop. This is not convenient as I'll need to use multiple
> instance for the tonecure which is far more generic than the basecurve.
>
> Anyway, I'm a bit confused with the way the presets from the new
> dt-curve-tool works.
>
> Thanks!
>
> -
> --
>   Pascal Obry /  Magny Les Hameaux (78)
>
>   The best way to travel is by means of imagination
>
>   http://v2p.fr.eu.org
>   http://www.obry.net
>
>   gpg --keyserver keys.gnupg.net --recv-key F949BD3B
>
>
>
> ------------------------------------------------------------------------------
> Want fast and easy access to all the code in your enterprise? Index and
> search up to 200,000 lines of code with a free copy of Black Duck
> Code Sight - the same software that powers the world's largest code
> search on Ohloh, the Black Duck Open Hub! Try it now.
> http://p.sf.net/sfu/bds
> _______________________________________________
> darktable-devel mailing list
> darktable-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/darktable-devel
>
------------------------------------------------------------------------------
Want fast and easy access to all the code in your enterprise? Index and
search up to 200,000 lines of code with a free copy of Black Duck
Code Sight - the same software that powers the world's largest code
search on Ohloh, the Black Duck Open Hub! Try it now.
http://p.sf.net/sfu/bds
_______________________________________________
darktable-devel mailing list
darktable-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/darktable-devel

Reply via email to