Hi Edouard, > 1) Why aren't toncurves showing up when adding the entry to > presets_from_basecurve ? > > Roman did remove the lines injecting the preset in the DB because a > warning would prevent compilation of DT if the basecurve array was > empty [1]. This was totally justified because of the warning treated > as error policy in DT.
No, that's not the issue. I did uncomment these lines and got the preset in the tonecurve but nothing in the basecure. > 2) Why is the preset array called xxx_from_basecurve ? > > Because at first dt-curve-tool was simply call basecurve. I'll submit > a PR for changing the name of the array. Good. > 3) Why should you disable basecurve when using the computed > tonecurve ? > > I added support for tonecurve because I was totally unsatisfied by the > current basecurve approach which is plainly wrong with regard to > expected colorimetric results[2]. Hence the exclusive use. Frankly, since 2 years of using the basecurve for the D800 I cannot say that I'm unsatisfied. The result was really good, and with the latest version of dt-curve-tool I have even better result with the basecure. I tested the basecure only and the tonecurve only and got indistinguishable results. > I just wanted to experimentally prove that a late real tonecurve would > greatlly improve my photo colors, and help some modules do a better > work with linear data as input. I could confirm on my side both > improvements, but I was still unsatisfied of color saturation with the > single tonecurve applied. Colors were lacking some pop. Using the basecurve I have a bit too much saturation compared to the D800 camera jpeg. So I cannot confirm your experiment. -- Pascal Obry / Magny Les Hameaux (78) The best way to travel is by means of imagination http://v2p.fr.eu.org http://www.obry.net gpg --keyserver keys.gnupg.net --recv-key F949BD3B ------------------------------------------------------------------------------ Want fast and easy access to all the code in your enterprise? Index and search up to 200,000 lines of code with a free copy of Black Duck Code Sight - the same software that powers the world's largest code search on Ohloh, the Black Duck Open Hub! Try it now. http://p.sf.net/sfu/bds _______________________________________________ darktable-devel mailing list darktable-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/darktable-devel
