fwiw, i just exported an upsampled image from dt, with a patch that changes
four lines of code (see end of this mail). i want to stress that this is
less work than writing a single email in this thread.. at least doing a
terrible job at it that is. it'll still use our high quality interpolation
filters (whatever you set in settings, lanczos3 or similar). i think it'll
even upsample during demosaic and then run all the other modules in
high-res (added noise grain etc), but would need to double check.
cheers,
jo
git diff
diff --git a/src/common/imageio.c b/src/common/imageio.c
index 490bd56..2abe741 100644
--- a/src/common/imageio.c
+++ b/src/common/imageio.c
@@ -675,8 +675,8 @@ int dt_imageio_export_with_flags(const uint32_t imgid,
const char *filename,
: high_quality;
const int width = high_quality_processing ? 0 : format_params->max_width;
const int height = high_quality_processing ? 0 :
format_params->max_height;
- const double scalex = width > 0 ? fminf(width /
(double)pipe.processed_width, 1.0) : 1.0;
- const double scaley = height > 0 ? fminf(height /
(double)pipe.processed_height, 1.0) : 1.0;
+ const double scalex = width > 0 ? fminf(width /
(double)pipe.processed_width, 100.0) : 1.0;
+ const double scaley = height > 0 ? fminf(height /
(double)pipe.processed_height, 100.0) : 1.0;
const double scale = fminf(scalex, scaley);
int processed_width = scale * pipe.processed_width + .5f;
int processed_height = scale * pipe.processed_height + .5f;
@@ -690,10 +690,10 @@ int dt_imageio_export_with_flags(const uint32_t
imgid, const char *filename,
{
dt_dev_pixelpipe_process_no_gamma(&pipe, &dev, 0, 0, processed_width,
processed_height, scale);
const double scalex = format_params->max_width > 0
- ? fminf(format_params->max_width /
(double)pipe.processed_width, 1.0)
+ ? fminf(format_params->max_width /
(double)pipe.processed_width, 100.0)
: 1.0;
const double scaley = format_params->max_height > 0
- ? fminf(format_params->max_height /
(double)pipe.processed_height, 1.0)
+ ? fminf(format_params->max_height /
(double)pipe.processed_height, 100.0)
: 1.0;
const double scale = fminf(scalex, scaley);
processed_width = scale * pipe.processed_width + .5f;
On Thu, Feb 5, 2015 at 4:07 PM, Pascal Obry <pas...@obry.net> wrote:
> 2015-02-05 14:42 GMT+01:00 Richard Levitte <rich...@levitte.org>:
> > You know, there are all kinds of ways you could have expressed that
> > without going for a wholier-than-thou kind of position.
>
> Or maybe because I'm not native English and that I did not choose the
> right words. In any case I didn't meant to close the door, just explain
> that "it is expected to have a small print as we currently get the
> DPI from the printer and respect that".
>
> Better?
>
> > So please, I can perfectly understand not upscaling now or ever from a
> > purely programmatic point of view. Maybe you'd rather leave that to
> > some other software for all I know, because it already does this
> > perfectly well? But as for judging the quality of a picture, PLEASE
> > leave that to each photographer and his/her intent. It's really not
> > your job or priviledge to pass judgement on pictures or prints thereof
> > when you haven't even seen them.
>
> Whooo! You had a bad day?
>
> Sorry but you can also step to do the job.
>
> In any case if there is demands for this it will be done at some point.
>
> Yet we need some big warnings as scaling up at some point will
> get very bad it depends on the factor.
>
> Something that should be done ASAP is at least give an hint that
> the picture won't fill all the page. The print module does display
> full page where the print is not, and this is clearly wrong.
>
> Regards,
>
> --
> Pascal Obry / Magny Les Hameaux (78)
>
> The best way to travel is by means of imagination
>
> http://v2p.fr.eu.org
> http://www.obry.net
>
> gpg --keyserver keys.gnupg.net --recv-key F949BD3B
>
>
> ------------------------------------------------------------------------------
> Dive into the World of Parallel Programming. The Go Parallel Website,
> sponsored by Intel and developed in partnership with Slashdot Media, is
> your
> hub for all things parallel software development, from weekly thought
> leadership blogs to news, videos, case studies, tutorials and more. Take a
> look and join the conversation now. http://goparallel.sourceforge.net/
> _______________________________________________
> darktable-devel mailing list
> darktable-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/darktable-devel
>
------------------------------------------------------------------------------
Dive into the World of Parallel Programming. The Go Parallel Website,
sponsored by Intel and developed in partnership with Slashdot Media, is your
hub for all things parallel software development, from weekly thought
leadership blogs to news, videos, case studies, tutorials and more. Take a
look and join the conversation now. http://goparallel.sourceforge.net/
_______________________________________________
darktable-devel mailing list
darktable-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/darktable-devel
