Kevin, I noticed the following code in your patch + + if (cpu_is_davinci_dm646x()) + davinci_serial_outb(p, UART_DM646X_SCR, 0x8);
You want to use writel. Less than 32bit Writes to the UART controller locks up the ARM core. Steve On Thursday 13 November 2008 16:15:36 Kevin Hilman wrote: > Steve Chen <[EMAIL PROTECTED]> writes: > > > Kevin, > > > > On Thursday 13 November 2008 13:17:39 Kevin Hilman wrote: > >> Is this misbehavior specific to the DM6467 EVM or common to any DM6467 > >> board? The patch description could be a bit more descriptive in the > >> future. > > Last month, someone posted on the mailing list about UART2 not working his > > custom board. As it turns out, he needed this same fix for UART2, so this > > is > > a generic dm6467 issue. > > OK, thanks for the clarification. That's what I was expecting. Then > doing this in board init code is definitely wrong. > > > Also, this patch only fixes UART0. Do we want to consider something more > > generic that addresses all three UARTs. > > Yes, I'd like to see something more generic. > > The 2nd patch I sent is an attempt at doing something more generic, > but it doesn't boot. Since the initial mis-behavior was not well > described in the initial patch, I'm hoping someone (like you :) might > be able to shed some light on why my solution doesn't work. > > Kevin > _______________________________________________ Davinci-linux-open-source mailing list [email protected] http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source
