Hi Hugo,
> ---
> arch/arm/mach-davinci/Kconfig | 23 ++
> arch/arm/mach-davinci/Makefile | 2 +
> arch/arm/mach-davinci/board-sffsdr.c | 223 +++++++++++++
> arch/arm/mach-davinci/sffsdr-fpga.c | 501
> +++++++++++++++++++++++++++++
> include/asm-arm/plat-sffsdr/sffsdr-fpga.h | 30 ++
Do we need to create new plat-xxx directory for this board? I should
go in plat-davinci I believe.
> diff --git a/arch/arm/mach-davinci/Makefile b/arch/arm/mach-davinci/Makefile
> index 420a33e..8478220 100644
> --- a/arch/arm/mach-davinci/Makefile
> +++ b/arch/arm/mach-davinci/Makefile
> @@ -11,3 +11,5 @@ obj-y := time.o irq.o clock.o
> serial.o io.o id.o psc.o \
> obj-$(CONFIG_MACH_DAVINCI_EVM) += board-dm644x-evm.o
> obj-$(CONFIG_MACH_DAVINCI_DM646X_EVM) += board-dm646x-evm.o
> obj-$(CONFIG_MACH_DAVINCI_DM355_EVM) += board-dm355-evm.o
> +obj-$(CONFIG_MACH_DAVINCI_SFFSDR) += board-sffsdr.o
> +obj-$(CONFIG_SFFSDR_FPGA) += sffsdr-fpga.o
Why can't this be in drivers/ directory?
> +
> +int __init sffsdr_fpga_init(void)
> +{
This should be static.
> +
> +void __exit sffsdr_fpga_exit(void)
> +{
Ditto.
--
---Trilok Soni
http://triloksoni.wordpress.com
http://www.linkedin.com/in/triloksoni
_______________________________________________
Davinci-linux-open-source mailing list
[email protected]
http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source
