Hi Dave, one comment below
On Tue, 9 Dec 2008 02:42:24 -0800, David Brownell <[EMAIL PROTECTED]> wrote: > @@ -1319,8 +1315,18 @@ static int davinci_mmcsd_probe(struct pl > host = mmc_priv(mmc); > host->mmc = mmc; /* Important */ > > + r = platform_get_resource(pdev, IORESOURCE_DMA, 0); > + if (!r) > + goto out; > + host->rxdma = r->start; > + > + r = platform_get_resource(pdev, IORESOURCE_DMA, 1); > + if (!r) > + goto out; > + host->txdma = r->start; > + > host->mem_res = mem; > - host->base = ioremap(r->start, SZ_4K); > + host->base = ioremap(mem->start, SZ_4K); what happens if we get a chip with different size here ? Would it be safer to use mem->end - mem->start instead of SZ_4K ?? Or maybe use that mem_size value ?? -- Best Regards, Felipe Balbi http://blog.felipebalbi.com [EMAIL PROTECTED] _______________________________________________ Davinci-linux-open-source mailing list [email protected] http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source
