On Tuesday 09 December 2008, Felipe Balbi wrote:
> since you're also cleaning it up, how about:

Not much -- most of that came from catching the error
returns from mmc_add_host(), and insisting that have
returned before calling anything that implicitly
relies on it having returned.

I have cleanup patches too.  :)


> if (IS_ERR(host->clk)) {
>         ret = PTR_ERR(host->clk);
>         goto out;
> }

Sure, that's a better error handling idiom, and since
I added the IS_ERR() bit this is best done as part of
that change.

- Dave


_______________________________________________
Davinci-linux-open-source mailing list
[email protected]
http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source

Reply via email to