Hi Dave,
quick comment below
On Tue, 9 Dec 2008 02:43:51 -0800, David Brownell <[EMAIL PROTECTED]>
wrote:
> @@ -1333,12 +1334,14 @@ static int davinci_mmcsd_probe(struct pl
> spin_lock_init(&host->lock);
>
> ret = -ENXIO;
> - host->clk = clk_get(NULL, "MMCSDCLK");
> - if (host->clk) {
> + host->clk = clk_get(&pdev->dev, "mmc");
> + if (!IS_ERR(host->clk)) {
> clk_enable(host->clk);
> host->mmc_input_clk = clk_get_rate(host->clk);
> - } else
> + } else {
> + ret = PTR_ERR(host->clk);
> goto out;
> + }
since you're also cleaning it up, how about:
if (IS_ERR(host->clk)) {
ret = PTR_ERR(host->clk);
goto out;
}
clk_enable(host->clk);
...
--
Best Regards,
Felipe Balbi
http://blog.felipebalbi.com
[EMAIL PROTECTED]
_______________________________________________
Davinci-linux-open-source mailing list
[email protected]
http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source
