Hard-wires the controller base register; use what ioremap()
returns, and offsets from that, so it handles multiple SPI
controllers (as on dm355). Don't use davinci_{readl,writel}
and friends.
Doesn't handle 8-bit words ... i.e. the default. Also,
valid word lengths are from 2..16 bits, not 8..16 bits,
in this hardware.
Just use dev_dbg(), not a custom spew_debug().
Since it doesn't handle any per-transfer options, check
for them when messages are submitted ... reject messages
that need such options.
Might as well manage the SPI_LSB_FIRST bit too.
I don't think I see any point to the IRQ support, or
the empty cleanup() method.
Don't disable the controller during setup(); there may
be an ongoing transfer on a different chipselect.
Don't do pinmuxing in this driver; that should be done
at board setup time.
The remove() method needs to shut down the workqueue.
- Dave
_______________________________________________
Davinci-linux-open-source mailing list
[email protected]
http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source
