I appreciate the review.
David Brownell wrote:
I don't think I see any point to the IRQ support, or
There is no need presently for the interrupt handler, however I think
using it for a completion to notify the read/duplex routines would
provide better support for SPI data transfer. I am currently only using
SPI for control. Is there a benefit over the polling of RXINTFLAG I am
currently using? If not, I can just drop it.
the empty cleanup() method.
Don't disable the controller during setup(); there may
be an ongoing transfer on a different chipselect.
I am a bit confused how there could be another transfer active. Can you
explain this?
_______________________________________________
Davinci-linux-open-source mailing list
[email protected]
http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source
