David Brownell <[email protected]> writes: > On Thursday 05 February 2009, Kevin Hilman wrote: >> Notes: >> - boot-tested on dm6446, dm355, dm6467 > > Minor glitch on dm355 in procfs: ref_clk isn't hooked up > to the PSC. Nor to the PLL, for that matter... maybe it > should just use a null string for non-PSC clocks.
Same on dm64xx as well. I noticed it too but didn't yet decide what to do with the proc dump. The /proc dump only has two types of clocks: PLL or PSC, and the ref_clk technically is neither. You'll notice I removed the 'CLK_PLL' flag from ref_clk because of the new init and handling of PLL-derived clocks. NULL for non-PSC clocks would be ok, but the ARMCLK doesn't have an LPSC associated with it either, and is not PLL derived. The other related thing left to fix is the fact that clk_enable calls psc_init on !CLK_PLL clocks, and it probably should only be called for clocks with valid lpsc field. i.e. some !PLL clocks like ARMCLK no not actually have PSC, at least on some devices. Kevin > I'd go for merging this. That way I'll have fewer patches > in my quilt series. ;) > > ref_clk users=12 psc 24000000 Hz > pll1 users=12 pll 432000000 Hz > pll1_sysclk1 users= 1 pll 216000000 Hz > ARMCLK users= 1 psc 216000000 Hz > mjcp users= 0 psc 216000000 Hz > pll1_sysclk2 users= 7 pll 108000000 Hz > uart2 users= 0 psc 108000000 Hz > asp0_clk users= 0 psc 108000000 Hz > asp1_clk users= 1 psc 108000000 Hz > MMCSDCLK0 users= 1 psc 108000000 Hz > MMCSDCLK1 users= 1 psc 108000000 Hz > ... _______________________________________________ Davinci-linux-open-source mailing list [email protected] http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source
