On Wednesday 18 February 2009, Mark A. Greer wrote: > +DAVINCI_SOC_START(dm355) > + .cpu_clks = dm355_clks, > + .mux_pins = dm355_pins, > + .mux_pins_num = ARRAY_SIZE(dm355_pins), > +DAVINCI_SOC_END
That counts as a gratuitous/needless use of macros. Just use normal struct decls for this stuff, it'll be a lot more clear what's going on. Also, correct me if I'm wrong but the EDMA init will need to grow up a bit too ... e.g. register a SOC-specific platform_device in the soc-specific init logic, grow platform_data to describe how many TCs it's got (dm646x has more than two) and how many hardware channels it's got (OMAP-L1xx has just 32, not 64), use ioremap(), etc. (That's sort of the converse of this patch ... removing some pseudo-commonality.) - Dave _______________________________________________ Davinci-linux-open-source mailing list [email protected] http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source
