On Thu, Feb 26, 2009 at 09:10:12AM -0800, Kevin Hilman wrote: > "Mark A. Greer" <[email protected]> writes: > > > From: Mark A. Greer <[email protected]>
> > +++ b/arch/arm/mach-davinci/common.c > > @@ -0,0 +1,56 @@ > > +/* > > + * Code commons to all DaVinci SoCs. > > + * > > + * Author: Mark A. Greer <[email protected]> > > + * > > + * 2009 (c) MontaVista Software, Inc. This file is licensed under > > + * the terms of the GNU General Public License version 2. This program > > + * is licensed "as is" without any warranty of any kind, whether express > > + * or implied. > > + */ > > +#include <linux/bootmem.h> > > + > > +#include <mach/clock.h> > > +#include <mach/mux.h> > > +#include <mach/common.h> > > + > > +struct davinci_soc_info *davinci_soc_info; > > + > > This current approach will not quite work for current modules that use > cpu_is_* because the davinci_soc_info symbol is not exported to > modules. This causes it not to build for DaVinci git but it actually > exposes a problem that needs to be fixed. In general, drivers > shouldn't be using cpu_is_* in the first place. Ideally, they should > be using platform_data for this. > > This currently only affects MMC and MUSB. Actually, its worse. Looks like: mmc, mtd/nand, emac, and musb. Mark -- _______________________________________________ Davinci-linux-open-source mailing list [email protected] http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source
