Hi Purshotam,
> +
> +
> +/* MMCSD Init clock in Hz in opendain mode */
s/opendain/opendrain
> +
> +static irqreturn_t mmc_davinci_irq(int irq, void *dev_id)
> +{
> + struct mmc_davinci_host *host = (struct mmc_davinci_host *)dev_id;
Unnecessary casting from void *.
> +
> + ret = -EBUSY;
> + mem_size = r->end - r->start + 1;
How about using resource_size(...) ?
> + mem = request_mem_region(r->start, mem_size, pdev->name);
> + if (!mem)
> + goto out;
> +
> +
> +MODULE_LICENSE("GPL");
> +MODULE_DESCRIPTION("MMC/SD driver for Davinci MMC controller");
Adding MODULE_AUTHOR and MODULE_ALIAS would be great. You can also add
MAINTAINERS entry if you want.
--
---Trilok Soni
http://triloksoni.wordpress.com
http://www.linkedin.com/in/triloksoni
_______________________________________________
Davinci-linux-open-source mailing list
[email protected]
http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source
