> And there are other DaVinci chips that support MMC too ... > some are compatible with those two chips, some not, all > should use a version of this driver. (And OMAP-L137 too, > same tech family but with a different marketing label.) > > So I'd remove the implication that DaVinci == DM6446, or > that this driver is specific to that SoC.
I will update the description as suggested by you when I will re-submit. > > +config MMC_DAVINCI > > + tristate "TI DAVINCI Multimedia Card Interface support" > > + depends on MMC > > Everything in that menu depends on MMC. This should > depend on ARCH_DAVINCI instead. :) I will add "depends on ARCH_DAVINCI" > > + host->clk = clk_get(&pdev->dev, NULL); > > The NULL won't work with the clock code currently > included in mainline ... "MMCSDCLK" will though. I will take care of this by changing to "MMCSDCLK" from NULL. > > + if (pdata->max_freq) > > + mmc->f_max = pdata->max_freq; > > + if (pdata->caps) > > + mmc->caps |= pdata->caps; > > A build-time issue is that "struct davinci_mmc_config" > is missing. You could update this patch to include > "arch/arm/mach-davinci/include/mach/mmc.h" too. I will add in the patch as well. - Purushotam _______________________________________________ Davinci-linux-open-source mailing list [email protected] http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source
