I noticed a newish bug in probe() ...

On Monday 16 March 2009, Purushotam Kumar wrote:
> +       if (!pdata || pdata->wires == 4 || pdata->wires == 0)
> +               mmc->caps |= MMC_CAP_4_BIT_DATA;

So pdata may be null.  But, if it is, then ...

> +
> +       mmc->ops = &mmc_davinci_ops;
> +       mmc->f_min = 312500;
> +       mmc->f_max = 25000000;
> +       if (pdata->max_freq)
> +               mmc->f_max = pdata->max_freq;

Oops!

> +       if (pdata->caps)
> +               mmc->caps |= pdata->caps;

Double oops!


_______________________________________________
Davinci-linux-open-source mailing list
[email protected]
http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source

Reply via email to